[PATCH 3/3] [RFC] ARM: prepare ARMv7-M for MULTIPLATFORM use

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Mon Sep 30 12:02:19 EDT 2013


Hello Arnd,

On Mon, Sep 30, 2013 at 12:34:25PM +0200, Arnd Bergmann wrote:
> On Monday 30 September 2013, Uwe Kleine-König wrote:
> > v7-M is a third group that is incompatible with both v4/v5 and v6/v7.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> > ---
> > This behaves strange but I think is robust not to allow broken configs:
> > 
> > When v4/v5 is selected, v6/v7 and v7m are available for enabling, too.
> > When v6/v7 is selected the other choices are disabled
> > When v7m is selected only v6/v7 are available for enabling.
> 
> The Kconfig stuff all looks good, 
> 
> Acked-by: Arnd Bergmann <arnd at arndb.de>
Thanks

> > @@ -141,3 +139,7 @@ ENTRY(vector_table)
> >  	.rept	64 - 16
> >  	.long	__irq_entry		@ 16..64 - External Interrupts
> >  	.endr
> > +
> > +	.globl  handle_arch_irq
> > +handle_arch_irq:
> > +	.long	0
> > -- 
> > 1.8.4.rc3
> 
> I'm not sure about this part. I guess you should either make it
> a separate patch, or describe what it's for in the patch description above.
This is needed because ARCH_MULTIPLATFORM selects MULTI_IRQ_HANDLER
which v7-M didn't use up to now. I will wait for a while for more
feedback then respin with a better changelog.
 
> Also, I'd put all of the text you have in the comment into the actual
> changeset text, above the --- line, as others might find that useful
> later.
ok

Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list