[PATCH v4 07/11] ARM: OMAP2+: CM: AM43x clockdomain data

[Paul Walmsley]

Hi

On Thu, 26 Sep 2013, Afzal Mohammed wrote:

> From: Ambresh K <ambresh at ti.com>
> 
> Add the data file to describe clock domains in AM43x SoC.
> OMAP4 clockdomain operations is being reused here.
> 
> Signed-off-by: Ambresh K <ambresh at ti.com>
> Signed-off-by: Afzal Mohammed <afzal at ti.com>
> ---
>  arch/arm/mach-omap2/clockdomain.h           |   2 +
>  arch/arm/mach-omap2/clockdomains43xx_data.c | 196 ++++++++++++++++++++++++++++
>  arch/arm/mach-omap2/cminst44xx.c            |   9 ++
>  3 files changed, 207 insertions(+)
>  create mode 100644 arch/arm/mach-omap2/clockdomains43xx_data.c
> 

...

> diff --git a/arch/arm/mach-omap2/clockdomains43xx_data.c b/arch/arm/mach-omap2/clockdomains43xx_data.c
> new file mode 100644
> index 0000000..6d71c60
> --- /dev/null
> +++ b/arch/arm/mach-omap2/clockdomains43xx_data.c
> @@ -0,0 +1,196 @@

...

> +static struct clockdomain l3s_tsc_43xx_clkdm = {
> +	.name		  = "l3s_tsc_clkdm",
> +	.pwrdm		  = { .name = "wkup_pwrdm" },
> +	.prcm_partition	  = AM43XX_CM_PARTITION,
> +	.cm_inst	  = AM43XX_CM_WKUP_INST,
> +	.clkdm_offs	  = AM43XX_CM_WKUP_L3S_TSC_CDOFFS,
> +	.flags		  = CLKDM_CAN_SWSUP,
> +};

The references to "wkup_pwrdm" on some of these clockdomains don't 
look right to me.  For example, this clockdomain is listed as being in 
AM43XX_CM_WKUP_INST, but its enclosing powerdomain is listed as being in 
AM43XX_PRM_WKUP_INST.  Looks to me like it's best to have two different 
wakeup powerdomains: one CM_WKUP, and one PRM_WKUP.
 

- Paul