[PATCH 2/3] ARM: mxs: crypto: Add Freescale MXS DCP driver
Marek Vasut
marex at denx.de
Sun Sep 29 18:09:50 EDT 2013
Dear Fabio Estevam,
[...]
> > + * There can even be only one instance of the MXS DCP due to the
> > + * design of Linux Crypto API.
>
> Is this true? Usually we don't want to create a global struct.
Yeah, unfortunatelly :-(
>
> > +
> > +/* AES 128 ECB and AES 128 CBC */
> > +static struct crypto_alg dcp_aes_algs[] = {
> > + [0] = {
>
> No need for explicitely add this [0]
I wanted to be explicit here, but OK.
[...]
Rest is fixed, thanks!
Best regards,
Marek Vasut
More information about the linux-arm-kernel
mailing list