[PATCH] media: i2c: adv7343: fix the DT binding properties

Mark Brown broonie at kernel.org
Tue Sep 24 11:54:43 EDT 2013


On Mon, Sep 23, 2013 at 01:50:51PM +0200, Laurent Pinchart wrote:

> Isn't regulator_get_optional() intended for devices that can have supplies 
> unconnected in normal use ? The ADV7343 supplies are mandatory from a hardware 
> point of view, so I think we should use regulator_get(). Otherwise the driver 
> won't be able to tell the difference between a regulator that isn't present 
> yet (for instance because the regulator device/driver hasn't been probed yet), 
> which should result in deferred probing, and an always-on regulator that has 
> been left out.

Yes, everything you say here is correct.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130924/fc1dba98/attachment-0001.sig>


More information about the linux-arm-kernel mailing list