[PATCH 1/1] ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd

Nishanth Menon nm at ti.com
Mon Sep 23 22:24:06 EDT 2013


On Mon, Sep 23, 2013 at 10:28 AM, Balaji T K <balajitk at ti.com> wrote:
> On Saturday 21 September 2013 12:41 AM, Nishanth Menon wrote:
>>
>> On 09/20/2013 12:38 PM, Balaji T K wrote:
>>>
>>> correct mux mode for mmc1_cmd to detect eMMC on bone-black
>>>
>>> Signed-off-by: Balaji T K <balajitk at ti.com>
>>> ---
>>>   arch/arm/boot/dts/am335x-bone-common.dtsi |    2 +-
>>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi
>>> b/arch/arm/boot/dts/am335x-bone-common.dtsi
>>> index 56361ce..90ab56c 100644
>>> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
>>> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
>>> @@ -117,7 +117,7 @@
>>>                 emmc_pins: pinmux_emmc_pins {
>>>                         pinctrl-single,pins = <
>>>                                 0x80 (PIN_INPUT_PULLUP | MUX_MODE2) /*
>>> gpmc_csn1.mmc1_clk */
>>> -                               0x84 (PIN_INPUT_PULLUP | MUX_MODE1) /*
>>> gpmc_csn2.mmc1_cmd */
>>> +                               0x84 (PIN_INPUT_PULLUP | MUX_MODE2) /*
>>> gpmc_csn2.mmc1_cmd */
>>>                                 0x00 (PIN_INPUT_PULLUP | MUX_MODE1) /*
>>> gpmc_ad0.mmc1_dat0 */
>>>                                 0x04 (PIN_INPUT_PULLUP | MUX_MODE1) /*
>>> gpmc_ad1.mmc1_dat1 */
>>>                                 0x08 (PIN_INPUT_PULLUP | MUX_MODE1) /*
>>> gpmc_ad2.mmc1_dat2 */
>>>
>> is'nt this a common change? why is it "black only"? if it is so, then
>> the pinmux should probably be spun off outside bone-common.dtsi into
>> boneblack.dtsi perhaps?
>>
>
> It is applicable for add-on eMMC-cape for beagle bone white, so eMMC pinmux
> can
> remain in bone-common.dtsi.
> However I could test only on beagle bone black which has eMMC on board,
> since I
> don't have access to eMMC-cape


Could you update the patch to the effect please considering you are
modifying am335x-bone-common.dtsi

Regards,
Nishanth Menon



More information about the linux-arm-kernel mailing list