[PATCH] ARM: OMAP: fix return value check in omap_device_build_from_dt()

Tony Lindgren tony at atomide.com
Tue Sep 17 19:29:24 EDT 2013


* Kevin Hilman <khilman at linaro.org> [130826 17:17]:
> Tony Lindgren <tony at atomide.com> writes:
> 
> > Kevin,
> >
> > * Wei Yongjun <weiyj.lk at gmail.com> [130704 06:48]:
> >> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
> >> 
> >> In case of error, the function omap_device_alloc() returns ERR_PTR()
> >> and never returns NULL. The NULL test in the return value check
> >> should be replaced with IS_ERR().
> >
> > Looks like this is still pending, care to take this?
> 
> Acked-by: Kevin Hilman <khilman at linaro.org>
> 
> Looks fine to me, since I don't have anything else in the queue, feel
> free to queue up for fixes-non-critical.

Applying into omap-for-v3.12/fixes thanks.

Tony



More information about the linux-arm-kernel mailing list