[PATCH 206/228] cpufreq: sa11x0: remove calls to cpufreq_notify_transition()

Viresh Kumar viresh.kumar at linaro.org
Fri Sep 13 12:22:31 EDT 2013


On 13 September 2013 21:45, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> The patch to which I'm replying removes the above calls.  These calls are
> necessary to shutdown various bits of CPU-clock dependent hardware
> before changing the CPU clock, and restore them - reconfiguring them
> for the new clock rate after the transition has happened.
>
> So, if you're removing these calls, what replaces them?  I don't see
> anything which does without the above set.

The other patch on which you commented about unnecessary read
locks being taken:

[PATCH 181/228] cpufreq: move freq change notifications to cpufreq

That calls these notifiers, for all platforms except the ones that have
set CPUFREQ_ASYNC_NOTIFICATION, before and after calling
->target_index()..

And so functionally the code is supposed to be the same.. Unless I
have done some stupid mistake..



More information about the linux-arm-kernel mailing list