[PATCH v3 0/8] Add the Quadspi driver for vf610-twr

Gupta, Pekon pekon at ti.com
Wed Sep 11 08:26:10 EDT 2013


Hi Mark, Shijie,

> 
> > The LUT registers needs to be filled with the SPI NOR command, such
> > Fast-read/Quad-read.
> > So the Quadspi driver needs to know the spi commands, and that's why the
> > SPI driver has
> > references to the spi command opcodes.
> 
> Indeed - what I was wondering was if those opcodes could be requested
> from the flash driver rather than coded in there.

As the talk is going in SPI framework direction, therefore requesting again..
please do not clutter the *generic* SPI framework to pass on opcodes from
flash-driver (like m25p80). (Q)SPI framework should remain generic and
independent of any upper layer drivers.
Therefore I proposed DT based approach, as an alternative.
http://lists.infradead.org/pipermail/linux-mtd/2013-September/048552.html

But as Shijie's patches are centric to FSL use-case and qspi-controller,
so I cannot pursue my suggestions further.

>  The driver needs to
> write the commands to the device but it's not clear to me if it really
> needs to know the specific commands.

with regards, pekon


More information about the linux-arm-kernel mailing list