[PATCH 1/4] cpufreq: cpufreq-cpu0: assign cpu_dev correctly to cpu0 device

Guennadi Liakhovetski g.liakhovetski at gmx.de
Wed Sep 11 04:15:00 EDT 2013


Hi Sudeep

On Tue, 10 Sep 2013, Sudeep KarkadaNagesha wrote:

> From: Sudeep KarkadaNagesha <sudeep.karkadanagesha at arm.com>
> 
> Commit f837a9b5ab05c52a07108c6f09ca66f2e0aee757 "cpufreq: cpufreq-cpu0:
> remove device tree parsing for cpu nodes" assumed the pdev->dev is set to
> cpu0 device in the platform code. But it actually points to the virtual
> cpufreq-cpu0 platform device which is not present in the device tree.
> Most of the information needed by cpufreq is stored in cpu0 DT node.
> So cpu_dev must point to cpu0 device.
> 
> This patch fixes the wrong assignment to cpu_dev.
> 
> Reported-by: Guennadi Liakhovetski <g.liakhovetski at gmx.de>
> Cc: Shawn Guo <shawn.guo at linaro.org>
> Signed-off-by: Sudeep KarkadaNagesha <sudeep.karkadanagesha at arm.com>

Thanks for your patches

> ---
>  drivers/cpufreq/cpufreq-cpu0.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.=
> c
> index cbfffa9..78c49d8 100644
> --- a/drivers/cpufreq/cpufreq-cpu0.c
> +++ b/drivers/cpufreq/cpufreq-cpu0.c
> @@ -12,6 +12,7 @@
>  #define pr_fmt(fmt)=09KBUILD_MODNAME ": " fmt
> =20

Noone else seems to complain, but I don't think these =20, =09 etc. codes 
have been invented on my side and I don't think they belong here. I'm 
handling enough mails / patches daily to believe, that my mail system 
isn't the cause of this. Could you please verify and regenerate and 
resend? Unless I'm mistaken this looks like a corruption on your SMTP 
side.

Thanks
Guennadi

>  #include <linux/clk.h>
> +#include <linux/cpu.h>
>  #include <linux/cpufreq.h>
>  #include <linux/err.h>
>  #include <linux/module.h>
> @@ -177,7 +178,11 @@ static int cpu0_cpufreq_probe(struct platform_device *=
> pdev)
>  =09struct device_node *np;
>  =09int ret;
> =20
> -=09cpu_dev =3D &pdev->dev;
> +=09cpu_dev =3D get_cpu_device(0);
> +=09if (!cpu_dev) {
> +=09=09pr_err("failed to get cpu0 device\n");
> +=09=09return -ENODEV;
> +=09}
> =20
>  =09np =3D of_node_get(cpu_dev->of_node);
>  =09if (!np) {
> --=20
> 1.8.1.2
> 
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/



More information about the linux-arm-kernel mailing list