[PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

[Jürgen Beisert]

Hi Marek,

On Monday 09 September 2013 18:04:19 Marek Vasut wrote:
> > Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at
> > least for the 4 wire touchscreen.
> >
> > Signed-off-by: Juergen Beisert <jbe at pengutronix.de>
> > CC: linux-arm-kernel at lists.infradead.org
> > CC: devel at driverdev.osuosl.org
> > CC: Marek Vasut <marex at denx.de>
> > CC: Fabio Estevam <fabio.estevam at freescale.com>
> > CC: Jonathan Cameron <jic23 at cam.ac.uk>
>
> This patch seems to combine two things -- register access rework AND
> adjustment of the driver for MX23 touchscreen.

It reworks the register access to avoid the i.MX23/i.MX28 runtime decision all 
over the code again and again. This is what Dan has recommended in his 
comment.

> Btw the MX23 ADC was already supported,

No. This patch is the first in this series which brings in the specific 
register bits, because the ADC units in the i.MX23 and i.MX28 differ.

> so this "add i.MX23 support" commit message is not accurate.

Hmmm, what else do you think should I write?

Regards,
Juergen

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | http://www.pengutronix.de/  |