[PATCH] crypto: tegra: use kernel entropy instead of ad-hoc

Stephen Warren swarren at wwwdotorg.org
Mon Sep 9 12:02:04 EDT 2013


On 09/09/2013 01:35 AM, Linus Walleij wrote:
> The way I read the Tegra AES RNG is that it has a homebrew
> algorithm for initializing the 128bit RNG using timespec and
> the unique chip ID. This looks like reinventing the (square)
> wheel, instead just grab 128bits from the kernel entropy pool
> where the time and (after another patch) chip unique ID is
> already mixed in.
> 
> Incidentally this also gets rid of a rather ugly
> cross-dependence on the machine using an extern declaration.

This sounds reasonable to me, although I know little about the driver.
Varun, can you please comment?

Acked-by: Stephen Warren <swarren at nvidia.com>



More information about the linux-arm-kernel mailing list