[PATCH v2 2/4] ARM: dts: add fec phy reset for imx6sl evk board

[Sascha Hauer]

On Mon, Sep 09, 2013 at 10:53:36PM +0800, Shawn Guo wrote:
> On Tue, Sep 03, 2013 at 12:26:23PM +0800, Fugang Duan wrote:
> > Add fec phy gpio reset for imx6sl evk board. imx6sl evk board
> > use GPIO4_21 to do phy reset, so add phy-reset-gpios and
> > phy-reset-duration propery initial for fec device node.
> > 
> > Signed-off-by: Fugang Duan  <B38611 at freescale.com>
> 
> I have to drop this patch for now, because it causes a regression for
> me.
> 
> Before this patch, we can at least get a working fec driver in kernel if
> U-Boot sets it up properly, e.g. we download kernel from network.  But
> with the patch, the fec driver stops working on linux-next in the same
> use case.

I think the FEC driver has doesn't wait enough time after it deasserts
the phy reset before it accesses the phy. At least I once got the
impression, but I haven't digged deeper so far.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |