[PATCH 4/5] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

Dan Carpenter dan.carpenter at oracle.com
Fri Sep 6 08:26:11 EDT 2013


On Fri, Sep 06, 2013 at 12:08:42PM +0200, Juergen Beisert wrote:
> +static int mxs_lradc_read_ts_channel(struct mxs_lradc *lradc)
> +{
> +	u32 reg;
> +	int val;
> +
> +	reg = readl(lradc->base + LRADC_CTRL1);
> +
> +	/* only channels 3 to 5 are of interest here */
> +	if (reg & LRADC_CTRL1_LRADC_IRQ(TS_CH_YP)) {
> +		pr_devel("!3");

Gar.  I meant to comment on this the first time this patch was sent.

Please remove the pr_devel() calls.  They are nonsense.

regards,
dan carpenter




More information about the linux-arm-kernel mailing list