[PATCH 01/15] watchdog: orion: Remove unneeded BRIDGE_CAUSE clear

Gregory CLEMENT gregory.clement at free-electrons.com
Thu Sep 5 12:32:26 EDT 2013


On 27/08/2013 23:55, Thomas Petazzoni wrote:
> Dear Jason Cooper,
> 
> On Tue, 27 Aug 2013 17:41:21 -0400, Jason Cooper wrote:
>> On Tue, Aug 27, 2013 at 03:02:48PM -0600, Jason Gunthorpe wrote:
>>> Since this is so complex, maybe it is OK to abandon support for non-DT
>>> boards in the WDT driver? Watchdog is not critical functionality, so
>>> nobody should be critically impacted. Boards would have to migrate
>>> to DT to get WDT back?
>>
>> I'm not 100% opposed to this.  We need to give it careful thought, but
>> it may be a viable solution since we are at the "convert old boards to
>> DT" stage anyhow.  If we had ten more drivers and 6 release cycles in
>> front of us, I'd say no.
> 
> While we're close to full DT for mach-kirkwood and mach-dove, we're
> pretty far from that for mach-orion5x and mach-mv78xx0, and I believe
> both are using the orion_wdt driver.

Actually mach-mv78xx0 don't use orion_wdt driver. In KConfig it depends
on ARCH_ORION5X, ARCH_KIRKWOOD or ARCH_DOVE but not ARCH_MV78XX0.

Moreover the register mapping is not exactly the same than the one used for
orion5x, kirkwood and dove.

But mach-orion5x still uses the orion_wdt driver and is not yet fully
converted to DT.

> 
> Thomas
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the linux-arm-kernel mailing list