[PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver
Marek Vasut
marex at denx.de
Thu Sep 5 06:51:39 EDT 2013
Dear Dan Carpenter,
> On Thu, Sep 05, 2013 at 12:16:18PM +0200, Jürgen Beisert wrote:
> > I like this simplification, but all the other drivers for the MXS series
> > of SoCs don't use such a method. Do you think this "new style" will be
> > accepted?
>
> My lradc_plate_mask() is basically the same idea as what Marek said
> about putting the logic into the define.
>
> LRADC....IRQ_MASK(id) (((id) == MX23) ? 0x1ff : 0x1fff)
>
> I don't know why Marek is complaining about churn though. This is
> linux! We love churn! And especially in staging, it's our favorite
> thing. :P
About time to move this driver out of staging then ;-)
Best regards,
Marek Vasut
More information about the linux-arm-kernel
mailing list