[PATCH 08/14] ASoC: kirkwood: prefer external clock over internal clock

Russell King - ARM Linux linux at arm.linux.org.uk
Mon Sep 2 10:17:32 EDT 2013


On Mon, Sep 02, 2013 at 12:01:05PM +0100, Mark Brown wrote:
> On Sun, Sep 01, 2013 at 06:41:53PM +0200, Jean-Francois Moine wrote:
> > Russell King <rmk+kernel at arm.linux.org.uk> wrote:
> 
> > > +	} else if (rate == 44100 || rate == 48000 || rate == 96000) {
> 
> > The rate is always good, and having this test raises a compilation warning
> > (clks_ctrl may be not initialized).
> 
> That should be fixed - it might be worth keeping the test and adding an
> else with an error return for robustness.

I believe you already have a fix merged.  I don't have that fix in my tree.



More information about the linux-arm-kernel mailing list