[PATCH] clk: armada-370: fix tclk frequencies
simon.guinot at sequanux.org
Thu Oct 3 05:00:58 EDT 2013
On Wed, Oct 02, 2013 at 01:04:49PM -0400, Jason Cooper wrote:
> On Wed, Oct 02, 2013 at 06:57:54PM +0200, Simon Guinot wrote:
> > On Wed, Oct 02, 2013 at 12:22:21PM -0400, Jason Cooper wrote:
> > > Simon,
> > >
> > > On Wed, Oct 02, 2013 at 05:56:58PM +0200, Simon Guinot wrote:
> > > > Signed-off-by: Simon Guinot <simon.guinot at sequanux.org>
> > >
> > > Could you elaborate on this? What symptom did you notice? How did this
> > > fix it? When was the regression introduced?
> > Hi Jason,
> > While benchmarking Linux 3.12-rc3 on an Armada-370-RD, I noticed bad
> > networking performances... After some investigations, I found out that
> > the coalescence configuration (derived from the tclk) was suspect.
> > While checking for the tclk value, I found this typo. There is not much
> > to say about this patch except that the correct tclk frequencies for
> > Armada-370 are 166 and 200MHz, not 16.6 and 20MHz.
> Yes, I know it's simple, but it's a huge help to us when trying to
> decide whether or not to flag it for stable. fwiw, the regression was
> introduced by:
> 6b72333d clk: mvebu: add Armada 370 SoC-centric clock init
> and this should be applied from v3.11 onwards.
Ok, I will reword this commit. Note that this bug can't be called a
regression. The tclk frequencies array was wrong from the beginning:
97fa4cf4: clk: mvebu: add mvebu core clocks
The commit you pointed out simply moves the typo. I am not familiar
with the stable process but if needed I can provide a patch against
some stable branches.
Please let know how do you want handle this.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 198 bytes
Desc: Digital signature
More information about the linux-arm-kernel