[PATCH] clk: armada-370: fix tclk frequencies

Jason Cooper jason at lakedaemon.net
Wed Oct 2 13:04:49 EDT 2013


On Wed, Oct 02, 2013 at 06:57:54PM +0200, Simon Guinot wrote:
> On Wed, Oct 02, 2013 at 12:22:21PM -0400, Jason Cooper wrote:
> > Simon,
> > 
> > On Wed, Oct 02, 2013 at 05:56:58PM +0200, Simon Guinot wrote:
> > > Signed-off-by: Simon Guinot <simon.guinot at sequanux.org>
> > 
> > Could you elaborate on this?  What symptom did you notice?  How did this
> > fix it?  When was the regression introduced?
> 
> Hi Jason,
> 
> While benchmarking Linux 3.12-rc3 on an Armada-370-RD, I noticed bad
> networking performances... After some investigations, I found out that
> the coalescence configuration (derived from the tclk) was suspect.
> 
> While checking for the tclk value, I found this typo. There is not much
> to say about this patch except that the correct tclk frequencies for
> Armada-370 are 166 and 200MHz, not 16.6 and 20MHz.

Yes, I know it's simple, but it's a huge help to us when trying to
decide whether or not to flag it for stable.  fwiw, the regression was
introduced by:

  6b72333d clk: mvebu: add Armada 370 SoC-centric clock init

and this should be applied from v3.11 onwards.

thx,

Jason.



More information about the linux-arm-kernel mailing list