[PATCH] ARM: sunxi: stop timer from ticking before enabling interrupts

Marc Zyngier marc.zyngier at arm.com
Sat Nov 30 09:41:31 EST 2013


On 2013-11-30 14:15, Maxime Ripard wrote:

Hi Maxime,

> On Sat, Nov 30, 2013 at 12:53:15PM +0000, Marc Zyngier wrote:
>> The sun4i timer can still be ticking when we enable the interrupt.
>> If another timer is actually used (A7 architected timer, for 
>> example),
>> odds are that the interrupt will eventually fire with the 
>> event_handler
>> pointer being NULL.
>>
>> The obvious fix it to stop the timer before registering the 
>> interrupt.
>>
>> Observed and tested on sun7i (cubietruck).
>>
>> Signed-off-by: Marc Zyngier <marc.zyngier at arm.com>
>
> You can add my Acked-by, but you should rather send this to Daniel
> Lezcano, which is the clocksource/clockevent maintainer.

Thanks. I'll push that to Daniel directly.

Cheers,

         M.
-- 
Fast, cheap, reliable. Pick two.



More information about the linux-arm-kernel mailing list