[PATCH 03/04] ARM: shmobile: Genmai I2C-over-GPIO support

Laurent Pinchart laurent.pinchart at ideasonboard.com
Thu Nov 28 12:14:38 EST 2013


On Thursday 28 November 2013 21:11:48 Sergei Shtylyov wrote:
> On 27-11-2013 15:04, Wolfram Sang wrote:
> >> +		#address-cells = <1>;
> >> +		#size-cells = <0>;
> >> +
> >> +		eeprom: 24c128 at 50 {
> >> +			compatible = "at,24c128";
> > 
> > Minor nit: Should be a vendor name, not the name of the driver
> 
> Moreover, the node should be named generically, like "flash at 50", not
> "24c128 at 50".

Or, given that it's an eeprom, "eeprom at 50" ? :-)

-- 
Regards,

Laurent Pinchart




More information about the linux-arm-kernel mailing list