[PATCH] rtc: at91sam9: include <mach/hardware.h> explicitly

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Tue Nov 26 13:36:29 EST 2013


Hello Andrew,

On Tue, Nov 26, 2013 at 02:44:44PM +0100, Uwe Kleine-König wrote:
> On Tue, Nov 26, 2013 at 02:41:17PM +0100, Uwe Kleine-König wrote:
> > On Fri, Nov 15, 2013 at 03:00:58PM +0100, Uwe Kleine-König wrote:
> > > The driver needs the symbol AT91_SLOW_CLOCK which is defined in
> > > arch/arm/mach-at91/include/mach/hardware.h. This file is included
> > > implicitly via linux/module.h -> linux/kmod.h -> linux/gfp.h ->
> > > linux/mmzone.h -> linux/memory_hotplug.h -> linux/notifier.h ->
> > > linux/srcu.h -> linux/workqueue.h -> linux/timer.h -> linux/ktime.h ->
> > > linux/jiffies.h -> linux/timex.h -> mach/timex.h -> mach/hardware.h .
> > > 
> > > So better include it explicitly not only because the last link will go
> > > away soon.
> > > 
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> > Ping. Is this patch ok despite Jean-Christophe's objection?
> I saw that akpm already took it into his tree.
This patch is one of the last few that are needed to drop <mach/timex.h>
alltogether that I don't have an ack from the respective maintainer yet.

Can you give your ack instead of sending the patch to Linus, then I'd
take it with the patch dropping <mach/timex.h> to make it easier to
merge.

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list