[PATCH 1/4] mtd: spi-nor: move the SPI NOR commands to a new header file

Gupta, Pekon pekon at ti.com
Tue Nov 26 02:42:21 EST 2013


Hi Shijie,

Few feedbacks inline.. 

> From: Huang Shijie [mailto:b32955 at freescale.com]
> This patch adds a new header :spi-nor.h,
> and moves all the SPI NOR commands and relative macros into this new
> header.
> 
(1)
It's better to take all Flash vendor specific opcodes from DT.. 
With new framework we should do away with macros for each vendor,
instead let each board file provide this information based on flash device
which is mounted on it.

(2)
And also, I suggest not to touch m25p80 in anyway, bcoz it stable driver
used by many. So unless spi-nor framework is accepted and is stable we
m25p80 should continue working as it is.
Thus your patches should be independent of any existing driver or other
frameworks. This way it might get accepted fast. Then later you can provide
a way to attach m25p80 to spi-nor framework.
Thoughts ?


with regards, pekon



More information about the linux-arm-kernel mailing list