[PATCH v4 REPOST] ARM: vexpress/TC2: Implement MCPM power_down_finish()

Olof Johansson olof at lixom.net
Mon Nov 25 13:26:46 EST 2013


On Mon, Nov 25, 2013 at 10:02 AM, Nicolas Pitre
<nicolas.pitre at linaro.org> wrote:
> On Mon, 25 Nov 2013, Olof Johansson wrote:
>
>> Hi,
>>
>> > Since v3.13-rc1, mcpm backends must implement an additional method which
>> > the vexpress TC2 implementation doesn't have upstream, resulting in an
>> > ugly WARN_ON() during hotplug and kexec operations
>>
>> Please be more specific here. Which change in the 3.13 merge window caused this?
>
> Commit 0de0d6467525.
>
> The corresponding change to tc2-pm.c was initially posted at about the
> same time i.e. before the merge window, but it somehow fell into a
> crack.

Thanks, I'll add that reference to the patch description when I apply.

Looks like the MCPM-side patch was posted already back in Oct 1. I'm
not going to flame anyone over this, but it'd be nice if we could find
out about these things sooner, ideally when breakage hits -next. Dave,
next time I think I'd prefer to hear about it even if it is during the
merge window. :-)

Anyway, obviously it's needed and I'll apply it.


-Olof



More information about the linux-arm-kernel mailing list