[PATCH] of/platform: Fix no irq domain found errors when populating interrupts

Tony Lindgren tony at atomide.com
Fri Nov 22 20:15:16 EST 2013


* Tony Lindgren <tony at atomide.com> [131122 17:09]:
> * Russell King - ARM Linux <linux at arm.linux.org.uk> [131122 16:56]:
> > On Fri, Nov 22, 2013 at 04:43:35PM -0800, Tony Lindgren wrote:
> > > +		/* See of_device_resource_notify for populating interrupts */
> > > +		for (i = 0; i < num_irq; i++, res++) {
> > > +			res->flags = IORESOURCE_IRQ;
> > > +			res->start = -EPROBE_DEFER;
> > > +			res->end = -EPROBE_DEFER;
> > 
> > NAK.  Definitely a bad idea to start introducing magic values other into
> > resources.  Please don't do this.
> 
> Do you have any better ideas on how to sort out this issue then?

I guess we could allocate all the resources lazily here, I'll take a look
at that.

Tony



More information about the linux-arm-kernel mailing list