[PATCH v3 1/5] mfd: max14577: Add max14577 MFD driver core

[Lee Jones]

> > > +static struct mfd_cell max14577_devs[] = {
> > > +	{ .name = "max14577-muic", },
> > > +	{ .name = "max14577-regulator", },
> > > +	{ .name = "max14577-charger", },
> > > +};
> > 
> > If these all support device tree, shouldn't you be populating
> > max14577_devs[x].of_compatible too? That way the MFD core will
> > automatically setup your dev.of_node pointers for you?
> 
> Only the regulator driver uses bindings from DT and it searches for
> "regulators" node in parent's node:
> 	np = of_get_child_by_name(max14577->dev->of_node, "regulators");
> I can add of_compatible but I think this won't be reflected in actual
> DTS.

Well it should be. I'll reply to the other patch too.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog