[PATCH v3 3/4] ata: Add APM X-Gene SoC SATA host controller driver

Loc Ho lho at apm.com
Tue Nov 19 16:22:44 EST 2013


Hi Kishon,

>>> +
>>> +/* Temporary function until the PHY parameter API */
>>> +extern void xgene_ahci_phy_set_pq(struct phy *phy, int chan, int data);
>>> +extern void xgene_ahci_phy_set_spd(struct phy *phy, int chan, int gen);
>>
>> Ah, that should have been mentioned in the changeset text. Do you think you
>> can remove these for the final version?
> [Loc Ho]
> Yes... Krishon, can you provide an patch that allows me to accommodate
> this? Or should I come up one? I will trying to get rip of the first
> one. But I will need the function to set the PHY speed - for
> Gen2/Gen1. Let's plan on add these function:
>
> a. int (*set_speed)(int gen_speed) where gen_speed is either AUTO,
> GEN1, GEN2, or GEN3.
> b. Change the PHY init function to take an optional parameter. This
> would help my first function in case I can get rip of it.
>
[Loc Ho]
I will provide this patch as part of my next version to include an
function as follow:

int set_speed(struct *phy, int lane, u64 speed);

where lane indicates the lane of the PHY and speed is the PHY speed in hertz.

-Loc



More information about the linux-arm-kernel mailing list