[PATCH 0/9] ARM: sa1100: Rework IRQ handling

Linus Walleij linus.walleij at linaro.org
Tue Nov 19 15:24:31 EST 2013


On Tue, Nov 19, 2013 at 4:17 PM, Dmitry Eremin-Solenikov
<dbaryshkov at gmail.com> wrote:
> On 11/19/2013 05:00 PM, Linus Walleij wrote:

>> And that happens before the GPIO driver gets registered -> crash.
>
> That is not the issue. The real issue is h3xxx using those gpio's without
> previously calling gpio_request.

Really? But that wasn't done before this patch either.

It is basically OK to use the gpio_* functions before or
without requesting the GPIOs, it won't look nice but it
works.

> Unfortunately sa1100 driver doesn't have a
> good place to request gpios. When faced this problem during locomo
> refactoring, I ended up with the following piece of code:
(...)
> Russell, Linus, what do you think about the previous solution?

That looks OK but is that really the problem?

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list