[Cocci] Warning masked by BUG() when CONFIG_BUG is enabled
Julia Lawall
julia.lawall at lip6.fr
Sun Nov 17 09:47:52 EST 2013
> > As a side note, I noticed quite some instances of that pattern (switch
> > statement w/ a 'default' calling BUG()) while more carefully looking at
> > compilation output. I may get slapped for this, but just in case this
> > is indeed something which deserves to be fixed and can be fixed
> > automagically via some semantic patch, I have CC'ed Coccinelle people.
>
> I don't think this can be fixed in a generic way. This driver, for
> example, should IMO return -EINVAL when hitting default in probe and
> simply get rid of the other BUG() calls. No need to halt the kernel
> because of a broken match->data.
One could nevertheless perhaps use Coccinelle to find them, if there is
some possibility to fix them.
julia
More information about the linux-arm-kernel
mailing list