[PATCH] rtc: at91sam9: include <mach/hardware.h> explicitly

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Fri Nov 15 09:23:27 EST 2013


On 15:00 Fri 15 Nov     , Uwe Kleine-K??nig wrote:
> The driver needs the symbol AT91_SLOW_CLOCK which is defined in
> arch/arm/mach-at91/include/mach/hardware.h. This file is included
> implicitly via linux/module.h -> linux/kmod.h -> linux/gfp.h ->
> linux/mmzone.h -> linux/memory_hotplug.h -> linux/notifier.h ->
> linux/srcu.h -> linux/workqueue.h -> linux/timer.h -> linux/ktime.h ->
> linux/jiffies.h -> linux/timex.h -> mach/timex.h -> mach/hardware.h .
> 
> So better include it explicitly not only because the last link will go
> away soon.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

we should never use this symbol you need to request the clock clk32k

Best Regards,
J.
> ---
>  drivers/rtc/rtc-at91sam9.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c
> index 309b8b3..5963743 100644
> --- a/drivers/rtc/rtc-at91sam9.c
> +++ b/drivers/rtc/rtc-at91sam9.c
> @@ -24,7 +24,7 @@
>  
>  #include <mach/at91_rtt.h>
>  #include <mach/cpu.h>
> -
> +#include <mach/hardware.h>
>  
>  /*
>   * This driver uses two configurable hardware resources that live in the
> -- 
> 1.8.4.2
> 



More information about the linux-arm-kernel mailing list