[PATCH 1/2] chipidea: ci_hdrc_imx: Allow handling the clock for an USB phy/hub

Fabio Estevam festevam at gmail.com
Thu Nov 14 05:48:35 EST 2013


On Thu, Nov 14, 2013 at 7:56 AM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Thu, Nov 14, 2013 at 12:09:46AM -0200, Fabio Estevam wrote:
>> @@ -107,10 +108,22 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
>>               return ret;
>>       }
>>
>> +     data->clk_phy = devm_clk_get(&pdev->dev, "phy");
>> +     if (IS_ERR(data->clk_phy)) {
>> +             data->clk_phy = NULL;
>> +     } else {
>
> Please stop using NULL as a indicator with functions which only return
> failure as an error pointer.  Replace the above three lines with

Thanks, fixed it in v2.



More information about the linux-arm-kernel mailing list