[PATCH V4 0/6]USB: OHCI:Properly handle ohci_suspend()routine in bus glue

Majunath Goudar csmanjuvijay at gmail.com
Wed Nov 13 07:10:15 EST 2013


Suspend scenario in case of ohci bus glue was not properly handled as
it was not suspending generic part of ohci controller. Alan Stern suggested,
properly handle ohci suspend scenario.

Calling explicitly the ohci_suspend()routine will ensure proper handling
of suspend scenario.

This patch set is rebased on greghk/usb-next 3.13-rc1 and successfully 
built without any build error.

V3->V4:
     -Dropped "[PATCH 5/7] USB: OHCI: Properly handle ohci-ep93xx suspend" in
      this version, as H Hartley Sweeten has just submitted a patch to remove
      ohci-ep93xx entirely.

     -[PATCH 2/6] The ohci_suspend() calling after enable_irq_wake, if ohci_suspend
      fails disabling the irq.

     -Added Alan acked-by.


V2->V3:
      -Rewrote the remaining patches on top of the latest Greg usb-next branch.
      This patch set not gives any build error. Patch set is required for proper
      suspend of ohci host controller as Alan mentioned.

      -Initially when I wrote this patch set I was working in Linaro, now I am not
      part of Linaro that is why Linaro id is bouncing. Sending this patch set
      from personal mail id.

V1->V2:
       -This version is fixing the ohci-ep93xx build error reported by Olof Johansson:

        drivers/usb/host/ohci-ep93xx.c: In function 'ohci_hcd_ep93xx_drv_suspend':
        drivers/usb/host/ohci-ep93xx.c:126:2: error: implicit declaration of
        function 'ep93xx_stop_hc'

        Due to the build failure on  "[PATCH 5/11] USB: OHCI: Properly handle
        ohci-ep93xx suspend" following patches were reverted.
        [PATCH 1/11]USB: OHCI: Properly handle OHCI controller suspend
        [PATCH 2/11] USB: OHCI: Properly handle ohci-at91 suspend
        [PATCH 3/11] USB: OHCI: Properly handle ohci-s3c2410 suspend
        [PATCH 4/11] USB: OHCI: Properly handle ohci-da8xx suspend
        [PATCH 5/11] USB: OHCI: Properly handle ohci-ep93xx suspend
        [PATCH 6/11] USB: OHCI: Properly handle ohci-exynos suspend
        [PATCH 11/11] USB: OHCI: Properly handle ohci-spear suspend

        The following 4 patches are fine and present in usb-next
        Commit id "10abfa13"[PATCH 7/11] Properly handle ohci-omap suspend.
        Commit id "39dbd7df"[PATCH 8/11] Properly handle ohci-platform suspend.
        Commit id "4ceaa893"[PATCH 9/11] Properly handle ohci-pxa suspend.
        Commit id "f3c60599"[PATCH 10/11] Properly handle ohci-sm501 suspend.

        This patch set is working properly.

Majunath Goudar (6):
  USB: OHCI: Properly handle OHCI controller suspend
  USB: OHCI: Properly handle ohci-at91 suspend
  USB: OHCI: Properly handle ohci-s3c2410 suspend
  USB: OHCI: Properly handle ohci-da8xx suspend
  USB: OHCI: Properly handle ohci-exynos suspend
  USB: OHCI: Properly handle ohci-spear suspend

 drivers/usb/host/ohci-at91.c    |   11 +++++++++--
 drivers/usb/host/ohci-da8xx.c   |   16 ++++++++++++----
 drivers/usb/host/ohci-exynos.c  |   22 ++++++----------------
 drivers/usb/host/ohci-hcd.c     |    9 ++++++++-
 drivers/usb/host/ohci-s3c2410.c |   21 ++++-----------------
 drivers/usb/host/ohci-spear.c   |   12 +++++++++---
 6 files changed, 48 insertions(+), 43 deletions(-)

-- 
1.7.9.5




More information about the linux-arm-kernel mailing list