[PATCH] ARM: mvebu: Add Netgear ReadyNAS 2120 board
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Sun Nov 10 03:15:33 EST 2013
Dear Sebastian Hesselbarth,
On Sun, 10 Nov 2013 00:57:17 +0100, Sebastian Hesselbarth wrote:
> > arch/arm/boot/dts/armada-xp-netgear-rn2120.dts | 289 +++++++++++++++++++++++++
>
> Arnaud,
>
> thanks for providing this! I do have some comments below.
>
> we recently had a discussion about the naming of new DTS files, which
> proposes to name those after vendor,board.dts (or vendor-board.dts).
>
> I personally prefer vendor,board.dts which would give
> netgear,readynas-2120.dts based on your compatible below.
> The final call for ',' vs '-' has not been made, so I suggest Jason
> makes a call here.
Hum, do we really want that? The current naming scheme is really,
really great, because whenever you want to grep through all Armada
370/XP DTS, you just have to use armada-*, for all Kirkwood,
kirkwood-*. I've found this very very convenient to verify the
coherency between .dts/.dtsi for a given family of SoCs.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the linux-arm-kernel
mailing list