[patch] pinctrl: rockchip: testing the wrong variable
Heiko Stübner
heiko at sntech.de
Fri Nov 8 06:44:33 EST 2013
Am Freitag, 8. November 2013, 11:01:38 schrieb Dan Carpenter:
> There is a copy and paste bug so we test "info->reg_base" instead of
> "info->reg_pull".
>
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
Thanks for the catch
Acked-by: Heiko Stuebner <heiko at sntech.de>
> ---
> I can't compile this.
>
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c
> b/drivers/pinctrl/pinctrl-rockchip.c index e939c28..fe2ec1b 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -1453,8 +1453,8 @@ static int rockchip_pinctrl_probe(struct
> platform_device *pdev) if (ctrl->type == RK3188) {
> res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> info->reg_pull = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(info->reg_base))
> - return PTR_ERR(info->reg_base);
> + if (IS_ERR(info->reg_pull))
> + return PTR_ERR(info->reg_pull);
> }
>
> ret = rockchip_gpiolib_register(pdev, info);
More information about the linux-arm-kernel
mailing list