[patch 1/1] ARM: kirkwood: stop printk TCLK value at boot for DT boards

Sebastian Hesselbarth sebastian.hesselbarth at gmail.com
Fri Nov 8 04:37:34 EST 2013

On 11/08/2013 10:29 AM, Arnaud Patard (Rtp) wrote:
> Sebastian Hesselbarth <sebastian.hesselbarth at gmail.com> writes:
>> On 11/05/2013 07:09 PM, Arnaud Patard (Rtp) wrote:
>>> Commit 2326f04321a9 (ARM: kirkwood: convert to DT irqchip and clocksource)
>>> dropped the call to kirkwood_timer_init() when booting with DT.
>>> This results in kirkwood_tclk not being set and the boot message is now:
>>> Kirkwood: MV88F6281-A0, TCLK=0
>>> This patch modifies the message for printing only the kirkwood id,
>>> as it allows to detect if we're running A0/A1/... variants with a simple
>>> dmesg.
>> for DT based booting we also have the "Machine" printed right above the
>> "Kirkwood" string. Don't you think, that we can remove the pr_info
>> completely?
> The Machine give some valuable information as one can load wrong dtb
> (already happened here). Moreover, it's a of thing (see
> of_flat_dt_match_machine) so not something that can be decided on
> kirkwookd side.
> About possible redundancy of informations between the "Kirkwood:" and
> the "Machine" lines, the former one gives the stepping. This allows to
> know easily if kwboot has a chance to work on the serial port.

Ok, I see there is a use for it. So,

Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth at gmail.com>


More information about the linux-arm-kernel mailing list