[PATCH] mtd: atmel_nand: fix bug driver will in a dead lock if no nand detected

Brian Norris computersforpeace at gmail.com
Thu Nov 7 13:43:06 EST 2013


On Tue, Nov 05, 2013 at 05:59:07PM +0800, Josh Wu wrote:
> In the atmel driver probe function, the code shows like following:
>   atmel_nand_probe(...) {
>         ...
> 
>   err_nand_ioremap:
>         platform_driver_unregister(&atmel_nand_nfc_driver);
>         return res;
>   }
> 
> If no nand flash detected, the driver probe function will goto
> err_nand_ioremap label.
> Then platform_driver_unregister() will be called. It will get the
> lock of atmel_nand device since it is parent of nfc_device. The
> problem is the lock is already hold by atmel_nand_probe itself.
> So system will be in a dead lock.
> 
> This patch just simply removed to platform_driver_unregister() call.
> When atmel_nand driver is quit the platform_driver_unregister() will
> be called in atmel_nand_remove().
> 
> Signed-off-by: Josh Wu <josh.wu at atmel.com>

Pushed to l2-mtd.git, with a little extra note and a
Cc: <stable at vger.kernel.org>

Thanks,
Brian



More information about the linux-arm-kernel mailing list