mfd: ab8500-debug: Add wake-up info
Dan Carpenter
dan.carpenter at oracle.com
Thu Nov 7 08:43:26 EST 2013
What ever happened to this? Can "desc" be NULL or not?
regards,
dan carpenter
On Mon, Aug 26, 2013 at 06:09:08PM +0300, Dan Carpenter wrote:
> Hello Jonas Aaberg,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 2cf64e264828: "mfd: ab8500-debug: Add wake-up info" from
> May 31, 2012, leads to the following Smatch complaint:
>
> drivers/mfd/ab8500-debugfs.c:1609 ab8500_interrupts_print()
> warn: variable dereferenced before check 'desc' (see line 1603)
>
> drivers/mfd/ab8500-debugfs.c
> 1602 struct irq_desc *desc = irq_to_desc(line + irq_first);
> 1603 struct irqaction *action = desc->action;
> ^^^^^^^^^^^^
> Patch adds dereference.
>
> 1604
> 1605 seq_printf(s, "%3i: %6i %4i", line,
> 1606 num_interrupts[line],
> 1607 num_wake_interrupts[line]);
> 1608
> 1609 if (desc && desc->name)
> ^^^^
> Patch adds check.
>
> 1610 seq_printf(s, "-%-8s", desc->name);
> 1611 if (action) {
>
> regards,
> dan carpenter
More information about the linux-arm-kernel
mailing list