[PATCH 20/23] ARM: signal: sigreturn_codes should be endian neutral to work in BE8

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Wed Nov 6 03:46:04 EST 2013


Hello Victor,

On Tue, Nov 05, 2013 at 07:48:42PM -0800, Victor Kamensky wrote:
> Hi Uwe, and All,
> 
> On 5 November 2013 13:18, Uwe Kleine-König
> <u.kleine-koenig at pengutronix.de> wrote:
> 
> <snip>
> 
> >> +
> >> +#if __LINUX_ARM_ARCH__ <= 4
> >> +     /*
> >> +      * Note we manually set minimally required arch that supports
> >> +      * required thumb opcodes for early arch versions. It is OK
> >> +      * for this file to be used in combination with other
> >> +      * lower arch variants, since these code snippets are only
> >> +      * used as input data.
> >> +      */
> >> +     .arch armv4t
> >> +#endif
> >> +
> >> +     .section .rodata
> >> +     .global sigreturn_codes
> >> +     .type   sigreturn_codes, #object
> >> +
> >> +     .arm
> > This breaks a ARMv7-M build, see
> > http://arm-soc.lixom.net/buildlogs/misc/next-20131105-1-g2b29c44/buildall.arm.efm32_defconfig.log.failed
> 
> Could you please point to git tree and branch from which efm32_defconfig
> was built - I could not find such in my tree.
next-20131105 contains both, your patch and the efm32 support.
(i.e. git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
next/master)

The problem is, that armv7-M doesn't support ARM, only Thumb-2.
If you go the ifdef route, CONFIG_CPU_THUMBONLY is what you want to use.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list