[PATCH 2/3] clk: shmobile: Add MSTP clock support
Magnus Damm
magnus.damm at gmail.com
Wed Nov 6 03:33:39 EST 2013
Hi Laurent,
On Tue, Oct 29, 2013 at 11:55 PM, Laurent Pinchart
<laurent.pinchart+renesas at ideasonboard.com> wrote:
> MSTP clocks are gate clocks controlled through a register that handles
> up to 32 clocks. The register is often sparsely populated.
>
> Those clocks are found on Renesas ARM SoCs.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>
> ---
> .../bindings/clock/renesas,cpg-mstp-clocks.txt | 47 +++++
> drivers/clk/shmobile/Makefile | 1 +
> drivers/clk/shmobile/clk-mstp.c | 229 +++++++++++++++++++++
> include/dt-bindings/clock/r8a7790-clock.h | 56 +++++
> 4 files changed, 333 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt
> create mode 100644 drivers/clk/shmobile/clk-mstp.c
Thanks for this. The MSTP driver looks fine to me, but..
> create mode 100644 include/dt-bindings/clock/r8a7790-clock.h
.. why do you bundle r8a7790-specific bits with the generic MSTP
driver in this patch?
It looks to me that you want these r8a7790 bits included with the
r8a7790 support code.
Cheers,
/ magnus
More information about the linux-arm-kernel
mailing list