[PATCH v3 22/28] mtd: nand: pxa3xx: Introduce multiple page I/O support
Brian Norris
computersforpeace at gmail.com
Tue Nov 5 14:08:08 EST 2013
One more thing on this patch:
On Tue, Nov 05, 2013 at 09:55:29AM -0300, Ezequiel Garcia wrote:
> @@ -437,7 +487,7 @@ static void disable_int(struct pxa3xx_nand_info *info, uint32_t int_mask)
>
> static void handle_data_pio(struct pxa3xx_nand_info *info)
> {
> - unsigned int do_bytes = min(info->data_size, info->fifo_size);
> + unsigned int do_bytes = min(info->data_size, info->chunk_size);
After this change, you no longer are using fifo_size globally (you only
use it locally in pxa3xx_nand_detect_config() to set the chunk_size).
Perhaps you can drop the field?
>
> switch (info->state) {
> case STATE_PIO_WRITING:
Brian
More information about the linux-arm-kernel
mailing list