[PATCH 2/3] ARM: mm: fix __phys_to_virt to work with 64 bit phys_addr_t in BE case

Russell King - ARM Linux linux at arm.linux.org.uk
Tue Nov 5 10:17:07 EST 2013


On Mon, Nov 04, 2013 at 06:16:04PM -0800, Victor Kamensky wrote:
>  static inline unsigned long __phys_to_virt(phys_addr_t x)
>  {
>  	unsigned long t;
> -	__pv_stub(x, t, "sub", __PV_BITS_31_24);
> +        /*
> +         * 'unsigned long' cast discard upper word when
> +         * phys_addr_t is 64 bit, and makes sure that inline
> +         * assembler expression receives 32 bit argument
> +         * in place where 'r' 32 bit operand is expected.
> +         */

We use tabs for indentation in the kernel source, not 8 spaces.  Please
fix before final submission, thanks. :)



More information about the linux-arm-kernel mailing list