[PATCH v5 1/4] ARM: deprecate mach/timex.h for !ARCH_MULTIPLATFORM

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Tue Nov 5 05:01:42 EST 2013


On Tue, Nov 05, 2013 at 10:42:48AM +0100, Linus Walleij wrote:
> On Tue, Nov 5, 2013 at 10:12 AM, Uwe Kleine-König
> <u.kleine-koenig at pengutronix.de> wrote:
> 
> > +config NEED_MACH_TIMEX_H
> > +       bool
> > +       help
> > +         Select this when mach/timex.h is required to provide special
> > +         definitions for this platform. This should be avoided when possible.
> 
> OK this is no blocker, and do proceed with this as the kernel sure
> looks better after this than before it.
> 
> However as the next step I would prefer that we start to get rid of
> all the NEED_MACH_FOO_H used for just refactoring out headers.
> 
> Can we not completely do away with this header next, and provide
> the services it supplied locally in the mach-foo folder for these machines
> instead so we do not need to have all these Kconfig things and preserve
> the <mach/*> namespace for them?
> 
> The real trick is to make CLOCK_TICK_RATE and LATCH runtime
> variables instead of a compile-time variables, right? Can't we do
> this?
Well, for LATCH there is no problem because it just uses CLOCK_TICK_RATE
and if the latter is provided correctly there is no problem. However I
don't see a way how to determine CLOCK_TICK_RATE at runtime. IMHO here
you need to fix all users as I just did for the u300 timer code.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list