[PATCH v4 1/4] ARM: deprecate mach/timex.h for !ARCH_MULTIPLATFORM

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Tue Nov 5 03:33:36 EST 2013


On Mon, Nov 04, 2013 at 02:53:09PM +0100, Arnd Bergmann wrote:
> On Monday 04 November 2013, Uwe Kleine-König wrote:
> > While mach/timex.h isn't used for multi-platform builds it still is for
> > "normal" builds. As there are only three platforms that do something else
> > than only defining CLOCK_TICK_RATE (and these are probably easy to fix),
> > deprecate mach/timex.h and drop the corresponding files.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> 
> +LinusW, +rmk
> 
> I don't think we can do this (yet): IIRC, CLOCK_TICK_RATE is required
> at least for platforms using CONFIG_ARCH_USES_GETTIMEOFFSET (which
> is not allowed for multiplatform).
Hmm, I indeed missed some uses, i.e. ep93xx, mmp, netx, sa1100, u300,
ixp4xx and rpc use CLOCK_TICK_RATE (or LATCH). Also
drivers/rtc/rtc-pxa.c uses CLOCK_TICK_RATE. I didn't find that
ARCH_USES_GETTIMEOFFSET implies a use of CLOCK_TICK_RATE though. Did I
miss something?

For now I took the patch out of my next branch and will rework it to at
least let the above listed platforms also continue to use timex.h.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list