[PATCHv2 6/8] ASoC: fsl: add SGTL5000 based audio machine driver.

Li Xiubo B47053 at freescale.com
Tue Nov 5 01:17:32 EST 2013


> > >  sound/soc/fsl/fsl-sgtl5000-vf610.c | 208
> > > +++++++++++++++++++++++++++++++++++++
> >
> > I just doubt if this file naming is appropriate. Even if we might not
> > have rigor rule for the file names, according to existing ones, they
> > are all in a same pattern: [SoC name]-[codec name].c
> >
> > "imx-sgtl5000.c" for example
> >
> > I think it would make user less confused about what this file exactly
> > is if this machine driver also follow the pattern: vf610-sgtl5000.c
> >
> >
> > @Shawn
> >
> > What do you think about the file name?
> 
> Yeah, it would be better to name the file following the existing the
> pattern.
> 

Please see the next version.

Best Regards,
Xiubo




More information about the linux-arm-kernel mailing list