[RFC PATCH 2/2] USB: OHCI: add a name for the platform-private field

Alan Stern stern at rowland.harvard.edu
Fri May 31 10:05:41 EDT 2013


On Fri, 31 May 2013, Manjunath Goudar wrote:

> On 30 May 2013 22:56, Alan Stern <stern at rowland.harvard.edu> wrote:
> 
> > On Thu, 30 May 2013, Manjunath Goudar wrote:
> >
> > > This patch adds an ohci->priv field for private use by OHCI
> > > platform drivers.
> > >
> > > Until now none of the platform drivers has used this private space,
> > > but that's about to change in the next patch of this series.
> >
> > As far as I'm concerned, this doesn't need to be in a patch of its own.
> > It can be merged into the 1/3 patch of the previous series.  After all,
> > that patch adds the extra_priv_size field in ohci_driver_overrides,
> > which doesn't make much sense unless there's a way to refer to the
> > private part of the ohci_hcd structure
> 
> 
> 
>  Already 1/3 patch is merged into main line kernel.

Yeah, too late now.

> Two days back only I started making ohci-spera a separate driver ,that time
> I felt extra_priv_size field is required in ohci_driver_overrides that what
> I created separate patch.
> 
> extra_priv_size patch is related to Spear patch,If you are agree,I can add
> this patch with Spear patch,making Spear patch series.

No, we may as well keep it separate like this.

Alan Stern




More information about the linux-arm-kernel mailing list