[PATCH 05/11] ARM: shmobile: APE6EVM LAN9220 support

[Guennadi Liakhovetski]

Hi Olof

On Mon, 27 May 2013, Olof Johansson wrote:

> Hi,
> 
> Sorry, a bit behind on email and just discovered this.
> 
> On Wed, May 22, 2013 at 07:22:59PM +0200, Guennadi Liakhovetski wrote:
> 
> > > > The above didn't work in my tests without this:
> > > > 
> > > > diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts 
> > > > b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > > > index f603c69..4fb0102 100644
> > > > --- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > > > +++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > > > @@ -33,8 +33,10 @@
> > > >  	};
> > > >  
> > > >  	lbsc {
> > > > +		compatible = "simple-bus";
> > > >  		#address-cells = <1>;
> > > >  		#size-cells = <1>;
> > > > +		ranges = <0 0 0 0x80000000>;
> > > >  
> > > >  		ethernet at 8000000 {
> > > >  			compatible = "smsc,lan9118", "smsc,lan9115";
> > > > 
> > > 
> > > Could you please post this as a formal patch and indicate
> > > if you would like it included as a fix in v3.10 or not?
> > 
> > Can do that, sure, just thought maybe it would be better to fix the 
> > original patch. Besides, I wasn't sure what the correct values for 
> > "ranges" are, I just picked up something, that would be sufficient for 
> > ethernet. But if more devices are added to it in the future, maybe 
> > different ranges values would be needed. I think actually, lbsc should map 
> > the 3 BSC areas, so, the correct property would be
> > 
> > +		ranges = <0 0 0 0x14000000>;
> > 
> > > Also, I am curious to know what your tests are.
> > 
> > Just booting with NFS root. I think, anything involving ethernet. Without 
> > the "simple-bus" property the lbsc node doesn't get scanned, so, no device 
> > is added. Without "ranges" addresses cannot be mapped correctly.
> 
> Since it's a flat mapping you can just specify an empty "ranges" property, no
> need to actually define contents.

Yes, I knew about that, but does this also hold for busses with different 
#address-cells properties, i.e. between 64- and 32-bit busses?

> For more info, see http://devicetree.org/Device_Tree_Usage#Ranges_.28Address_Translation.29

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/