[PATCH v2 2/5] irqchip: mmp: support irqchip

Arnd Bergmann arnd at arndb.de
Tue May 28 13:26:47 EDT 2013


On Tuesday 28 May 2013, Haojian Zhuang wrote:
>         icu_data[0].domain = irq_domain_add_legacy(node, nr_irqs, 0, 0,
>                                                    &mmp_irq_domain_ops,
>                                                    &icu_data[0]);

Is there anything stopping you from converting to the linear domain now?

> +IRQCHIP_DECLARE(mmp_intc, "mrvl,mmp-intc", mmp_of_init);
> +IRQCHIP_DECLARE(mmp2_intc, "mrvl,mmp2-intc", mmp2_of_init);
> +IRQCHIP_DECLARE(mmp2_mux_intc, "mrvl,mmp2-mux-intc", mmp2_mux_of_init);

Please put each line directly after the function it refers to,
similar to how we do it for EXPORT_SYMBOL.

	Arnd



More information about the linux-arm-kernel mailing list