[PATCH] ARM: dt: Use the 'model' field for printing the hardware revision

Fabio Estevam festevam at gmail.com
Tue May 28 08:57:20 EDT 2013


Hi Uwe,

On Tue, May 28, 2013 at 9:15 AM, Uwe Kleine-König
<u.kleine-koenig at pengutronix.de> wrote:

>>  struct machine_desc {
>>       unsigned int            nr;             /* architecture number  */
>>       const char              *name;          /* architecture name    */
>> +     const char              *model;         /* architectute model */
> s/architectute/architecture/

Thanks for reviewing it. Will fix in v2.

>
> Is it really needed to add a new field here? Alternatively overwrite
> name or do something like:
>
>         if (this_is_a_device_tree_machine)
>                 seq_printf(m, "Hardware\t: %s\n", get_model_from_dt());
>         else
>                 seq_printf(m, "Hardware\t: %s\n", machine_name);

I was not able to find a good trick that provides me the
'this_is_a_device_tree_machine' information inside the c_show()
function, so I ended up adding a the model inside machine_desc struct.

Regards,

Fabio Estevam



More information about the linux-arm-kernel mailing list