[PATCH] ARM: mach-shmobile: r8a7790: add SATA support

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Thu May 23 22:21:17 EDT 2013


Hi Simon

> > +static __init void r8a7790_register_sata1(void)
> > +{
> > +
> > +	struct resource res[] = {
> > +		DEFINE_RES_MEM_NAMED(0xee300000, 0x200000, "rcar-sata"),
> > +		DEFINE_RES_IRQ(gic_iid(106)),
> > +	};
> > +
> > +	struct platform_device_info pdevinfo = {
> > +		.name = "sata_rcar",
> > +		.id = 1,
> > +		.res = res,
> > +		.num_res = ARRAY_SIZE(res),
> > +		.dma_mask = DMA_BIT_MASK(32),
> > +	};
> > +
> > +	platform_device_register_full(&pdevinfo);
> > +}

This "using local variable" make sense.
It don't need "__initdata"


Best regards
---
Kuninori Morimoto



More information about the linux-arm-kernel mailing list