[PATCH v2 0/3] Marvell PCIe driver improvements

[Jason Cooper]

On Thu, May 23, 2013 at 04:32:50PM +0200, Thomas Petazzoni wrote:
> Bjorn, Jason, Andrew, Gregory,
> 
> Here is an updated version of the PCIe improvements.
> 
> Changes since v1:
> 
>  * Fix some typos in the comments of PATCH 2, noticed by Bjorn
>    Helgaas.
> 
>  * Rework the two last patches (first one was fixing the capability
>    list, the other one the emulation of the devsel bits in the status
>    register), after the comments of Bjorn. In fact, it turns out that
>    the status register is composed of read-only bits for which we want
>    to emulate a value of zero, and the other bits are write-1-to-clear
>    bits that expose error conditions that we do not handle in the
>    emulated bridge. So, in summary, emulating a 0 status register on
>    reads, and ignoring writes to the status register is the simplest
>    solution. If we later on implement a capability list, we can use a
>    more clever emulation of the status register, but for the moment,
>    this simple solution is enough. Therefore, the two last patches are
>    now one single, simpler patch.
> 
> I'd like those improvements to be kept separated from the original
> PCIe driver itself: while the PCIe driver has been around and reviewed
> for a long time, those improvements are newer. And I clearly do not
> want the PCIe driver to miss 3.11 because of any problem that could be
> found in those additional improvements.
> 
> The main improvement being brought here is that the PCI-to-PCI bridge
> logic is fixed/extended to properly support physical PCIe bridges that
> are connected on a PCIe interface of a Marvell board. Without this
> improvement, only the devices connected directly to the PCIe
> interfaces of the board are properly enumerated. Any device that would
> sit beyond a physical bridge is not visible.
> 
> Bjorn, with your Acked-by, could the Marvell maintainers include those
> patches in their branch, merged through arm-soc? They already have the
> Marvell PCIe driver itself, so I believe it makes sense to merge those
> improvements through the same path.
> 
> Jason, those patches have been prepared on top of my marvell-pcie-v10
> branch, I hope that's ok for you. If you want me to rebase them on
> some other branch in which you have integrated the PCIe driver, don't
> hesitate to tell me to do so. That said, since those patches are only
> touching the driver itself and no other file, they should not cause
> any conflict with other changes.
> 
> Thanks,
> 
> Thomas
> 
> Thomas Petazzoni (3):
>   pci: mvebu: no longer fake the slot location of downstream devices
>   pci: mvebu: allow the enumeration of devices beyond physical bridges
>   pci: mvebu: fix the emulation of the status register
> 
>  drivers/pci/host/pci-mvebu.c |   55 +++++++++++++++++++++++++++++++++---------
>  1 file changed, 44 insertions(+), 11 deletions(-)

Whole series applied to mvebu/pcie_bridge with Bjorn's Ack.  The whole
pcie tree now looks like:

        /-mvebu/of_pci  /-mvebu/pcie
        |               |
+---+---+---+---+---+---+---+---+---+---+ mvebu/pcie_bridge
                        |
                        \---+---+---+---+ mvebu/pcie_kirkwood
(not to scale :) )

This is getting pretty hairy, do you intend on anything else for mvebu
pcie for this merge window?

thx,

Jason.