Re[2]: [PATCH] ARM: dts: imx: fix clocks for cspi

Alexander Shiyan shc_work at mail.ru
Thu May 23 08:10:59 EDT 2013


> > The CSPI controller has only one clock, but the driver spi-imx.c needs clock "per" to calculate bitrate divisor.
> > 
> > Signed-off-by: Jonas Andersson <jonas at microbit.se>
> > ---
> >  arch/arm/boot/dts/imx25.dtsi | 12 ++++++------
> >  arch/arm/boot/dts/imx27.dtsi |  6 +++---
> >  arch/arm/boot/dts/imx51.dtsi |  2 +-
> >  arch/arm/boot/dts/imx53.dtsi |  2 +-
> >  4 files changed, 11 insertions(+), 11 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> > index d2550e0..7011539 100644
> > --- a/arch/arm/boot/dts/imx25.dtsi
> > +++ b/arch/arm/boot/dts/imx25.dtsi
> > @@ -141,8 +141,8 @@
> >  				#size-cells = <0>;
> >  				compatible = "fsl,imx25-cspi", "fsl,imx35-cspi";
> >  				reg = <0x43fa4000 0x4000>;
> > -				clocks = <&clks 62>;
> > -				clock-names = "ipg";
> > +				clocks = <&clks 62>, <&clks 62>;
> > +				clock-names = "ipg", "per";
> >  				interrupts = <14>;
> >  				status = "disabled";
> >  			};

Sorry, typo.

> Why you do not use "dummy" clock for "per" here?

*for "ipg"

> This variant will request/enable one clock two times.
 
---


More information about the linux-arm-kernel mailing list